dev-haskell/data-lens
Used to be Haskell 98 Lenses
Screenshots
View
Download
BrowseChangeLog
commit c1d1ab135e7d4c3de68869388ff96abf77f868e5
Author: hololeap <hololeap@protonmail.com>
Date: Tue Mar 5 19:25:37 2024 -0700
*/*: Switch to EAPI 8
Signed-off-by: hololeap <hololeap@protonmail.com>
commit db98782e890b3cebf75a19b2da3a1bdcbee17fa4
Author: hololeap <hololeap@users.noreply.github.com>
Date: Fri May 12 06:28:08 2023 -0600
*/*: Remove [profile?] from ghc RDEPEND
This reverts commit b2f01bbf1333c88785109bebf75d49a3bd623727.
Adding [profile?] universally causes issues with exe-only packages with
no profile USE flag. This is better handled in the eclass.
Signed-off-by: hololeap <hololeap@users.noreply.github.com>
commit a2f524e74d7e5e5000c1d057a74dcd7f4af7b43c
Author: hololeap <hololeap@users.noreply.github.com>
Date: Sat May 6 17:04:20 2023 -0600
*/*: Remove ~x86 (and related) from KEYWORDS
x86 is mostly untested, and even building a subset of ::haskell
revealed failing tests which pass on amd64.
With the new behavior of hackport to only add ARCH to KEYWORDS, there
will be CI failures if a package has ~x86 removed but not from its
revdep tree as well. The only sensible mitigation is to remove ~x86
tree-wide until we have a dedicated tester willing to fix current bugs.
See: https://github.com/snoyberg/mono-traversable/issues/210
Signed-off-by: hololeap <hololeap@users.noreply.github.com>
commit b2f01bbf1333c88785109bebf75d49a3bd623727
Author: hololeap <hololeap@users.noreply.github.com>
Date: Fri May 5 15:53:40 2023 -0600
*/*: Add [profile?] to ghc RDEPEND
Any package that depends on 'base' will require the 'base' profiling
libs when profiling is enabled. Because virtually every package depends
on 'base', it makes sense to add [profile?] universally to
'dev-lang/ghc' in RDEPEND.
Reported-by: Filip Kszczot <filip@kszczot.pl>
Signed-off-by: hololeap <hololeap@users.noreply.github.com>
commit 9672ee12c9c489f9e5bfdee329a4e6aed692fe4d
Author: Sam James <sam@gentoo.org>
Date: Sat Jul 30 06:55:18 2022 +0100
*/*: fix https->https in metadatd dtd
Newer hackport fixes this (in git, not tagged yet).
Signed-off-by: Sam James <sam@gentoo.org>
commit dd87656fbe7504ff3fa2de1f4a58fd5b9885c693
Author: Wolfgang E. Sanyer <WolfgangESanyer@gmail.com>
Date: Thu Feb 25 20:34:18 2021 -0500
dev-haskell/data-lens: resolve DeprecatedEapi QA warning
Signed-off-by: Wolfgang E. Sanyer <WolfgangESanyer@gmail.com>
commit 9fa184c63396c386b5a3195e31e77dd29f389cbc
Author: Wolfgang E. Sanyer <WolfgangESanyer@gmail.com>
Date: Tue Feb 16 23:55:33 2021 -0500
dev-haskell/data-lens: remove redundant longdescription from metadata
Signed-off-by: Wolfgang E. Sanyer <WolfgangESanyer@gmail.com>
commit 3d16013c65cc8986c7537d76ed3a2855e978d057
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Sat Nov 23 15:39:53 2019 +0000
*/*: Inline mirror://hackage and update URIs
Follow ::gentoo commit 2a2e66a9407205f18
("*/*: Inline mirror://hackage and update URIs ")
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit db7990791e1e74d14f96ab27d49133181ff710bd
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Sun Nov 3 10:58:42 2019 +0000
dev-haskell/data-lens: allow ghc-8.6
Package-Manager: Portage-2.3.78, Repoman-2.3.17
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit 2a94f64d40e69b69ddfa1b5da7906d17009e5e6f
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Fri Nov 24 09:25:20 2017 +0000
refresh Manifests
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit 1a6ba469382ab24f8b77b4ff3b043b6e2ed68306
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Tue Feb 28 21:38:05 2017 +0000
follow ::gentoo in removing '# $Id$' headers
Done as
$ sed -i */*/*.ebuild -e '/^# \$Id\$$/d'
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit e02751ee58bc84577bb45ed34c1535b87de9e025
Author: Sergei Trofimovich <siarheit@google.com>
Date: Sat Jul 2 11:33:57 2016 +0100
dev-haskell/data-lens: allow semigroupoids-5.1
Package-Manager: portage-2.3.0
commit d3d903c246bc9d64f0a6ede8f001abd1768e25af
Author: Sergei Trofimovich <siarheit@google.com>
Date: Fri May 27 08:29:16 2016 +0100
dev-haskell/data-lens: allow transformers-0.5
Package-Manager: portage-2.3.0_rc1
commit 049943ec9293968927625daa17a086e736f95811
Author: Sergei Trofimovich <siarheit@google.com>
Date: Wed Feb 10 19:10:31 2016 +0000
dev-haskell/data-lens: tweak for comonad-5
Package-Manager: portage-2.2.27
commit 3a40c3d5f125bc626f95bf8442489653f1eecae9
Author: Sergei Trofimovich <siarheit@google.com>
Date: Wed Feb 10 18:22:07 2016 +0000
dev-haskell/data-lens: allow comonad-5.0
Package-Manager: portage-2.2.27
commit aa19eeb10bc2eb3e09f93fa8a102c322742943e4
Author: Vikraman Choudhury <vikraman@gentoo.org>
Date: Tue Jan 26 14:19:48 2016 -0500
Update metadata.xml for GLEP 67
commit 77bfc71d66aebed5c267cfc8980b563d5b01c3b7
Author: Sergei Trofimovich <siarheit@google.com>
Date: Mon Sep 21 09:29:14 2015 +0100
follow jlec@'s HOMEPAGE fix s/http:/https:/ form ::gentoo
The hack I did it is:
https://github.com/trofi/gentoo-qa/blob/master/check_homepage_https.sh
Will also need similar change in hackport.
Signed-off-by: Sergei Trofimovich <siarheit@google.com>
commit b9c11d9d44644f6a277de1f7af562de56e786675
Author: Sergei Trofimovich <siarheit@google.com>
Date: Sun Aug 9 10:37:52 2015 +0100
convert '# $Header: ' lines to '# $Id$'
The change was adopted when ::gentoo switched to git.
https://github.com/trofi/gentoo-qa/blob/master/check_header.sh
Signed-off-by: Sergei Trofimovich <siarheit@google.com>
commit 82fc07842a8eef62d5072e57ca2183ba5ea45e05
Author: Sergei Trofimovich <siarheit@google.com>
Date: Thu Jul 23 10:15:50 2015 +0100
dev-haskell/data-lens: bump up to 2.10.7
Package-Manager: portage-2.2.20
commit de115429b3723a8e180674e0a4b808e78d6bab18
Author: Sergei Trofimovich <siarheit@google.com>
Date: Sat Jun 6 18:30:41 2015 +0100
dev-haskell/data-lens: bump up to 2.10.6
Package-Manager: portage-2.2.20
commit 74e5c13fcccf91421fbacdc7a19f6a2eb71f5df5
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Sun Sep 28 21:54:07 2014 +0100
dev-haskell/data-lens: allow semigroupoids-4.2
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit 7caba65cd543fbfef1c994cc43a84a5dec653ce7
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Thu Jul 24 18:07:32 2014 +0300
metadata.xml: from <maintainer> field in favour of <herd> one
Mangled by tiny tool:
https://github.com/trofi/gentoo-qa/blob/master/shrink_haskell_metadata.hs
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit aa27b3ddcc31eb307f394863ae1effbb7ce29181
Author: Alexander Vershilov <alexander.vershilov@gmail.com>
Date: Thu May 15 14:46:58 2014 +0400
dev-haskell/data-lens: bump up to 2.10.5
commit 467fd21131ae14021f442ec1eb1485a8a531f172
Author: Alexander Berntsen <alexander@plaimi.net>
Date: Mon Mar 3 16:51:56 2014 +0100
dev-haskell/data-lens: Add USE description
commit f5464c3263f5a9e81600fe872acaeb69cd2c8f61
Author: Alexander Vershilov <alexander.vershilov@gmail.com>
Date: Thu Oct 31 10:38:25 2013 +0400
dev-haskell/data-lens: bump up to 2.10.4
Signed-off-by: Alexander Vershilov <alexander.vershilov@gmail.com>
commit 93eb3679dc96dd3958d55c81666088950febc075
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Sat Sep 28 14:21:28 2013 +0300
dev-haskell/data-lens: bump up to 2.10.3
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit f1b87c80da64d9d24175dcfa1c69615ee25d073a
Author: Mark Wright <gienah@gentoo.org>
Date: Sun Aug 25 10:44:35 2013 +1000
loosen comonad-transformers dep in data-lens
commit 4e3f4a2780ae638555a83f7d958cb8ac3a1af99e
Author: Mark Wright <gienah@gentoo.org>
Date: Wed Jul 24 21:17:37 2013 +1000
Loosen comonad dep in data-lens
commit 6fc8d317b7147a7febfc60a0ca37945e7423cd9d
Author: Alexander Vershilov <alexander.vershilov@gmail.com>
Date: Sat Jul 20 10:11:49 2013 +0400
update data-lens due to Q.A.
commit 7db4e1b65c2de61d0028528402e5f4d4f1112cf1
Author: Alexander Vershilov <alexander.vershilov@gmail.com>
Date: Fri Sep 7 17:44:46 2012 +0400
big mirror update
commit 9349ea6bab48899d5c3131b3efd209154dfbc657
Author: Mark Wright <gienah@gentoo.org>
Date: Sat Aug 11 00:31:06 2012 +1000
Bump data-lens to 2.10.2
commit d492cd9d0d1e05710f5eb148a45b38c6cf174109
Author: Mark Wright <gienah@gentoo.org>
Date: Sun Jul 8 00:23:00 2012 +1000
Bump data-lens deps
commit 88bbb0224ca4d45e00f0f64b16b0c8e79dab66f1
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Fri Jun 15 03:11:07 2012 +0300
regenerated all Manifests to make use of 'thin' feature in one shot
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit 040a9e5f27ad364e165e808cac21b58324c66001
Author: Mark Wright <gienah@gentoo.org>
Date: Sun May 13 21:46:07 2012 +1000
Loosen containers dep in data-lens for ghc 7.5
commit ee44ce3f072c270709e671be0db44535cce7cad3
Author: Mark Wright <gienah@gentoo.org>
Date: Thu Apr 12 02:14:09 2012 +1000
Bump data-lens to 2.10.0
commit 99110f17a463ccff733c2b38db7766e88764777d
Author: Mark Wright <gienah@gentoo.org>
Date: Sun Apr 1 00:58:12 2012 +1100
Bump contravariant dependency in data-lens-2.0.2-r1
commit ddfc3d1aa83b3634fb3be0d8024f3d6afe252445
Author: Mark Wright <markwright@internode.on.net>
Date: Thu Nov 17 23:17:59 2011 +1100
Add hoogle support
commit fbb9409864737b422133358d9215e4ea2c1c36a0
Author: Mark Wright <markwright@internode.on.net>
Date: Fri Oct 28 23:38:04 2011 +1100
Add data-lens, built with ghc 7.2.1, 7.0.4 and 6.12.3
Author: hololeap <hololeap@protonmail.com>
Date: Tue Mar 5 19:25:37 2024 -0700
*/*: Switch to EAPI 8
Signed-off-by: hololeap <hololeap@protonmail.com>
commit db98782e890b3cebf75a19b2da3a1bdcbee17fa4
Author: hololeap <hololeap@users.noreply.github.com>
Date: Fri May 12 06:28:08 2023 -0600
*/*: Remove [profile?] from ghc RDEPEND
This reverts commit b2f01bbf1333c88785109bebf75d49a3bd623727.
Adding [profile?] universally causes issues with exe-only packages with
no profile USE flag. This is better handled in the eclass.
Signed-off-by: hololeap <hololeap@users.noreply.github.com>
commit a2f524e74d7e5e5000c1d057a74dcd7f4af7b43c
Author: hololeap <hololeap@users.noreply.github.com>
Date: Sat May 6 17:04:20 2023 -0600
*/*: Remove ~x86 (and related) from KEYWORDS
x86 is mostly untested, and even building a subset of ::haskell
revealed failing tests which pass on amd64.
With the new behavior of hackport to only add ARCH to KEYWORDS, there
will be CI failures if a package has ~x86 removed but not from its
revdep tree as well. The only sensible mitigation is to remove ~x86
tree-wide until we have a dedicated tester willing to fix current bugs.
See: https://github.com/snoyberg/mono-traversable/issues/210
Signed-off-by: hololeap <hololeap@users.noreply.github.com>
commit b2f01bbf1333c88785109bebf75d49a3bd623727
Author: hololeap <hololeap@users.noreply.github.com>
Date: Fri May 5 15:53:40 2023 -0600
*/*: Add [profile?] to ghc RDEPEND
Any package that depends on 'base' will require the 'base' profiling
libs when profiling is enabled. Because virtually every package depends
on 'base', it makes sense to add [profile?] universally to
'dev-lang/ghc' in RDEPEND.
Reported-by: Filip Kszczot <filip@kszczot.pl>
Signed-off-by: hololeap <hololeap@users.noreply.github.com>
commit 9672ee12c9c489f9e5bfdee329a4e6aed692fe4d
Author: Sam James <sam@gentoo.org>
Date: Sat Jul 30 06:55:18 2022 +0100
*/*: fix https->https in metadatd dtd
Newer hackport fixes this (in git, not tagged yet).
Signed-off-by: Sam James <sam@gentoo.org>
commit dd87656fbe7504ff3fa2de1f4a58fd5b9885c693
Author: Wolfgang E. Sanyer <WolfgangESanyer@gmail.com>
Date: Thu Feb 25 20:34:18 2021 -0500
dev-haskell/data-lens: resolve DeprecatedEapi QA warning
Signed-off-by: Wolfgang E. Sanyer <WolfgangESanyer@gmail.com>
commit 9fa184c63396c386b5a3195e31e77dd29f389cbc
Author: Wolfgang E. Sanyer <WolfgangESanyer@gmail.com>
Date: Tue Feb 16 23:55:33 2021 -0500
dev-haskell/data-lens: remove redundant longdescription from metadata
Signed-off-by: Wolfgang E. Sanyer <WolfgangESanyer@gmail.com>
commit 3d16013c65cc8986c7537d76ed3a2855e978d057
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Sat Nov 23 15:39:53 2019 +0000
*/*: Inline mirror://hackage and update URIs
Follow ::gentoo commit 2a2e66a9407205f18
("*/*: Inline mirror://hackage and update URIs ")
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit db7990791e1e74d14f96ab27d49133181ff710bd
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Sun Nov 3 10:58:42 2019 +0000
dev-haskell/data-lens: allow ghc-8.6
Package-Manager: Portage-2.3.78, Repoman-2.3.17
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit 2a94f64d40e69b69ddfa1b5da7906d17009e5e6f
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Fri Nov 24 09:25:20 2017 +0000
refresh Manifests
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit 1a6ba469382ab24f8b77b4ff3b043b6e2ed68306
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Tue Feb 28 21:38:05 2017 +0000
follow ::gentoo in removing '# $Id$' headers
Done as
$ sed -i */*/*.ebuild -e '/^# \$Id\$$/d'
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit e02751ee58bc84577bb45ed34c1535b87de9e025
Author: Sergei Trofimovich <siarheit@google.com>
Date: Sat Jul 2 11:33:57 2016 +0100
dev-haskell/data-lens: allow semigroupoids-5.1
Package-Manager: portage-2.3.0
commit d3d903c246bc9d64f0a6ede8f001abd1768e25af
Author: Sergei Trofimovich <siarheit@google.com>
Date: Fri May 27 08:29:16 2016 +0100
dev-haskell/data-lens: allow transformers-0.5
Package-Manager: portage-2.3.0_rc1
commit 049943ec9293968927625daa17a086e736f95811
Author: Sergei Trofimovich <siarheit@google.com>
Date: Wed Feb 10 19:10:31 2016 +0000
dev-haskell/data-lens: tweak for comonad-5
Package-Manager: portage-2.2.27
commit 3a40c3d5f125bc626f95bf8442489653f1eecae9
Author: Sergei Trofimovich <siarheit@google.com>
Date: Wed Feb 10 18:22:07 2016 +0000
dev-haskell/data-lens: allow comonad-5.0
Package-Manager: portage-2.2.27
commit aa19eeb10bc2eb3e09f93fa8a102c322742943e4
Author: Vikraman Choudhury <vikraman@gentoo.org>
Date: Tue Jan 26 14:19:48 2016 -0500
Update metadata.xml for GLEP 67
commit 77bfc71d66aebed5c267cfc8980b563d5b01c3b7
Author: Sergei Trofimovich <siarheit@google.com>
Date: Mon Sep 21 09:29:14 2015 +0100
follow jlec@'s HOMEPAGE fix s/http:/https:/ form ::gentoo
The hack I did it is:
https://github.com/trofi/gentoo-qa/blob/master/check_homepage_https.sh
Will also need similar change in hackport.
Signed-off-by: Sergei Trofimovich <siarheit@google.com>
commit b9c11d9d44644f6a277de1f7af562de56e786675
Author: Sergei Trofimovich <siarheit@google.com>
Date: Sun Aug 9 10:37:52 2015 +0100
convert '# $Header: ' lines to '# $Id$'
The change was adopted when ::gentoo switched to git.
https://github.com/trofi/gentoo-qa/blob/master/check_header.sh
Signed-off-by: Sergei Trofimovich <siarheit@google.com>
commit 82fc07842a8eef62d5072e57ca2183ba5ea45e05
Author: Sergei Trofimovich <siarheit@google.com>
Date: Thu Jul 23 10:15:50 2015 +0100
dev-haskell/data-lens: bump up to 2.10.7
Package-Manager: portage-2.2.20
commit de115429b3723a8e180674e0a4b808e78d6bab18
Author: Sergei Trofimovich <siarheit@google.com>
Date: Sat Jun 6 18:30:41 2015 +0100
dev-haskell/data-lens: bump up to 2.10.6
Package-Manager: portage-2.2.20
commit 74e5c13fcccf91421fbacdc7a19f6a2eb71f5df5
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Sun Sep 28 21:54:07 2014 +0100
dev-haskell/data-lens: allow semigroupoids-4.2
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit 7caba65cd543fbfef1c994cc43a84a5dec653ce7
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Thu Jul 24 18:07:32 2014 +0300
metadata.xml: from <maintainer> field in favour of <herd> one
Mangled by tiny tool:
https://github.com/trofi/gentoo-qa/blob/master/shrink_haskell_metadata.hs
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit aa27b3ddcc31eb307f394863ae1effbb7ce29181
Author: Alexander Vershilov <alexander.vershilov@gmail.com>
Date: Thu May 15 14:46:58 2014 +0400
dev-haskell/data-lens: bump up to 2.10.5
commit 467fd21131ae14021f442ec1eb1485a8a531f172
Author: Alexander Berntsen <alexander@plaimi.net>
Date: Mon Mar 3 16:51:56 2014 +0100
dev-haskell/data-lens: Add USE description
commit f5464c3263f5a9e81600fe872acaeb69cd2c8f61
Author: Alexander Vershilov <alexander.vershilov@gmail.com>
Date: Thu Oct 31 10:38:25 2013 +0400
dev-haskell/data-lens: bump up to 2.10.4
Signed-off-by: Alexander Vershilov <alexander.vershilov@gmail.com>
commit 93eb3679dc96dd3958d55c81666088950febc075
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Sat Sep 28 14:21:28 2013 +0300
dev-haskell/data-lens: bump up to 2.10.3
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit f1b87c80da64d9d24175dcfa1c69615ee25d073a
Author: Mark Wright <gienah@gentoo.org>
Date: Sun Aug 25 10:44:35 2013 +1000
loosen comonad-transformers dep in data-lens
commit 4e3f4a2780ae638555a83f7d958cb8ac3a1af99e
Author: Mark Wright <gienah@gentoo.org>
Date: Wed Jul 24 21:17:37 2013 +1000
Loosen comonad dep in data-lens
commit 6fc8d317b7147a7febfc60a0ca37945e7423cd9d
Author: Alexander Vershilov <alexander.vershilov@gmail.com>
Date: Sat Jul 20 10:11:49 2013 +0400
update data-lens due to Q.A.
commit 7db4e1b65c2de61d0028528402e5f4d4f1112cf1
Author: Alexander Vershilov <alexander.vershilov@gmail.com>
Date: Fri Sep 7 17:44:46 2012 +0400
big mirror update
commit 9349ea6bab48899d5c3131b3efd209154dfbc657
Author: Mark Wright <gienah@gentoo.org>
Date: Sat Aug 11 00:31:06 2012 +1000
Bump data-lens to 2.10.2
commit d492cd9d0d1e05710f5eb148a45b38c6cf174109
Author: Mark Wright <gienah@gentoo.org>
Date: Sun Jul 8 00:23:00 2012 +1000
Bump data-lens deps
commit 88bbb0224ca4d45e00f0f64b16b0c8e79dab66f1
Author: Sergei Trofimovich <slyfox@gentoo.org>
Date: Fri Jun 15 03:11:07 2012 +0300
regenerated all Manifests to make use of 'thin' feature in one shot
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
commit 040a9e5f27ad364e165e808cac21b58324c66001
Author: Mark Wright <gienah@gentoo.org>
Date: Sun May 13 21:46:07 2012 +1000
Loosen containers dep in data-lens for ghc 7.5
commit ee44ce3f072c270709e671be0db44535cce7cad3
Author: Mark Wright <gienah@gentoo.org>
Date: Thu Apr 12 02:14:09 2012 +1000
Bump data-lens to 2.10.0
commit 99110f17a463ccff733c2b38db7766e88764777d
Author: Mark Wright <gienah@gentoo.org>
Date: Sun Apr 1 00:58:12 2012 +1100
Bump contravariant dependency in data-lens-2.0.2-r1
commit ddfc3d1aa83b3634fb3be0d8024f3d6afe252445
Author: Mark Wright <markwright@internode.on.net>
Date: Thu Nov 17 23:17:59 2011 +1100
Add hoogle support
commit fbb9409864737b422133358d9215e4ea2c1c36a0
Author: Mark Wright <markwright@internode.on.net>
Date: Fri Oct 28 23:38:04 2011 +1100
Add data-lens, built with ghc 7.2.1, 7.0.4 and 6.12.3